8000 [MonologBridge] Fix the Monlog ServerLogHandler from Hanging on Windows by ChadSikorra · Pull Request #22787 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[MonologBridge] Fix the Monlog ServerLogHandler from Hanging on Windows #22787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[MonologBridge] Fix the Monlog ServerLogHandler from Hanging on Windows #22787

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3b3448
Avoid timeouts when sending server log data via TCP.
ChadSikorra May 19, 2017
023cf01
Close the socket using stream_socket to avoid hangs.
ChadSikorra May 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Close the socket using stream_socket to avoid hangs.
  • Loading branch information
@ChadSikorra
ChadSikorra committed May 19, 2017
commit 023cf011456c81bdb4489f641a7bd7d46e00cbe3
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/Monolog/Handler/ServerLogHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function handle(array $record)
$recordFormatted = $this->formatRecord($record);

if (-1 === stream_socket_sendto($this->socket, $recordFormatted)) {
fclose($this->socket);
stream_socket_shutdown($this->socket, STREAM_SHUT_RDWR);

// Let's retry: the persistent connection might just be stale
if ($this->socket = $this->createSocket()) {
Expand Down
0