8000 [Console] Fix errors not rethrown even if not handled by console.error listeners by chalasr · Pull Request #22690 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Fix errors not rethrown even if not handled by console.error listeners #22690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2017
Merged

[Console] Fix errors not rethrown even if not handled by console.error listeners #22690

merged 1 commit into from
May 11, 2017

Conversation

chalasr
Copy link
Member
@chalasr chalasr commented May 11, 2017
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22678
License MIT
Doc PR n/a

#22261 has been squashed while revisiting error handling, this fixes it again while keeping latest changes intact.

code

public function execute(InputInterface $input, OutputInterface $output) {
    $this->barr();
}

public function bar() { }

before
before

after
after

@chalasr chalasr mentioned this pull request May 11, 2017
Closed
@fabpot
Copy link
Member
fabpot commented May 11, 2017

Thank you @chalasr.

@fabpot fabpot merged commit 75f098f into symfony:2.7 May 11, 2017
fabpot added a commit that referenced this pull request May 11, 2017
@fabpot
bug #22690 [Console] Fix errors not rethrown even if not handled by c…
05240ce 
…onsole.error listeners (chalasr)

This PR was merged into the 2.7 branch.

Discussion
----------

[Console] Fix errors not rethrown even if not handled by console.error listeners

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22678
| License       | MIT
| Doc PR        | n/a

#22261 has been squashed while revisiting error handling, this fixes it again while keeping latest changes intact.

__code__
```php
public function execute(InputInterface $input, OutputInterface $output) {
    $this->barr();
}

public function bar() { }
```

__before__
![before](http://image.prntscr.com/image/38aa3b46fed6439ead693908ab104fb3.png)

__after__
![after](http://image.prntscr.com/image/071322bfa52247c6a02eac6ef9d8284a.png)

Commits
-------

75f098f Fix errors not rethrown even if not handled by console.error listeners
@chalasr chalasr deleted the console-error-handling branch May 11, 2017 17:14
@ciaranmcnulty
Copy link
Contributor

Thanks @chalasr, this fixes the issue we had on PhpSpec

@fabpot fabpot mentioned this pull request May 17, 2017
Merged
This was referenced May 29, 2017
Merged
Merged
Merged
@FloatingMaster
Copy link

This pr breaks handling php \Throwable exceptions

see #18484

@chalasr
Copy link
Member Author
chalasr commented Jul 3, 2017

I don't get what you mean. Please open a new issue, I find no comments from you in the thread which is also closed thus won't be tracked

@chalasr
Copy link
Member Author
chalasr commented Jul 3, 2017 •
edited
Loading

(and the linked thread is older than this PR, not related)

@Seldaek Seldaek mentioned this pull request Mar 30, 2022
Closed
@chalasr chalasr mentioned this pull request Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Console Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chalasr @fabpot @ciaranmcnulty @FloatingMaster @carsonbot
0