Fixing a bug where abstract classes were wired with the prototype loader #22681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -108,7 +108,7 @@ private function findClasses($namespace, $pattern) | |||
| if (!$r = $this->container->getReflectionClass($class)) { | |||
| throw new InvalidArgumentException(sprintf('Expected to find class "%s" in file "%s" while importing services from resource "%s", but it was not found! Check the namespace prefix used with the resource.', $class, $path, $pattern)); | |||
| } | |||
| if (!$r->isInterface() && !$r->isTrait()) { | |||
| if (!$r->isInterface() && !$r->isTrait() && !$r->isAbstract()) { | |||
cd38948 to
ae3ebc2
Compare
GuilhemN
reviewed
May 11, 2017
| @@ -108,7 +108,8 @@ private function findClasses($namespace, $pattern) | |||
| if (!$r = $this->container->getReflectionClass($class)) { | |||
| throw new InvalidArgumentException(sprintf('Expected to find class "%s" in file "%s" while importing services from resource "%s", but it was not found! Check the namespace prefix used with the resource.', $class, $path, $pattern)); | |||
| } | |||
| if (!$r->isInterface() && !$r->isTrait()) { | |||
| // skip interfaces, traits, abstract classes & private constructors | |||
| if ($r->isInstantiable()) { | |||
There was a problem hiding this comment.
I'm not certain we should skip private constructors, users could define a factory when having some.
ae3ebc2 to
5326bab
Compare
|
I just changed away from |
GuilhemN
approved these changes
May 11, 2017
|
Thank you @weaverryan. |
fabpot
added a commit
that referenced
this pull request
May 11, 2017
…ototype loader (weaverryan)
This PR was merged into the 3.3-dev branch.
Discussion
----------
Fixing a bug where abstract classes were wired with the prototype loader
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | n/a
The prototype/PSR-4 loader currently tries to wire abstract classes. The problem is if, for example, you have, for example:
```php
abstract class BaseCommand extends Command
{
}
```
If this is registered as a service, and you have `autoconfigure`, then the console `Application` will try to use this a command.
Was there some reason abstract classes were originally allowed to be registered as services with the PSR4/prototype loader? I don't know if there is a real use-case for registering abstract classes. If you wanted to use that service as a parent service... then you'll probably be configuring it yourself anyways. We could also fix this by changing all tags compiler passes to skip classes that are abstract... *if* there is a use-case for Abstract classes being auto-registered.
Cheers!
Commits
-------
5326bab Fixing a bug where abstract classes were wired
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prototype/PSR-4 loader currently tries to wire abstract classes. The problem is if, for example, you have, for example:
If this is registered as a service, and you have
autoconfigure, then the consoleApplicationwill try to use this a command.Was there some reason abstract classes were originally allowed to be registered as services with the PSR4/prototype loader? I don't know if there is a real use-case for registering abstract classes. If you wanted to use that service as a parent service... then you'll probably be configuring it yourself anyways. We could also fix this by changing all tags compiler passes to skip classes that are abstract... if there is a use-case for Abstract classes being auto-registered.
Cheers!