8000 [Form] Add tel and color types by apetitpa · Pull Request #22679 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Add tel and color types #22679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

[Form] Add tel and color types #22679

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9b7c39d
add tel and color types
May 9, 2017
6a08ffb
remove duplication and add full name
May 9, 2017
60917c3
add tests for new types
May 9, 2017
bb0f316
add boostrap 3 layout tests for new types
May 9, 2017
9980a84
revert contributors to master branch
May 9, 2017
4c431e6
revert form.xml to master branch
May 9, 2017
b6d7177
update templates with new types and rename TelType to TelephoneType
May 9, 2017
081e64e
fix block prefix
May 9, 2017
3c14d32
update minimum version required
May 9, 2017
3c5f3eb
use class reference
May 10, 2017
e26e0ca
rename and fix tests
Oct 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add boostrap 3 layout tests for new types
  • Loading branch information
apetitpa committed Oct 2, 2017
commit bb0f3162155f30973db5e6c652ed46c8b10442d1
30 changes: 30 additions & 0 deletions src/Symfony/Component/Form/Tests/AbstractBootstrap3LayoutTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2468,4 +2468,34 @@ public function testButtonAttributeNameRepeatedIfTrue()
// foo="foo"
$this->assertSame('<button type="button" id="button" name="button" foo="foo" class="btn-default btn">[trans]Button[/trans]</button>', $html);
}

public function testTel()
{
$tel = '0102030405';
$form = $this->factory->createNamed('name', 'Symfony\Component\Form\Extension\Core\Type\TelType', $tel);

$this->assertWidgetMatchesXpath($form->createView(), array('attr' => array('class' => 'my&class')),
'/input
[@type="tel"]
[@name="name"]
[@class="my&class form-control"]
[@value="0102030405"]
'
);
}

public function testColor()
{
$color = '#0000ff';
$form = $this->factory->createNamed('name', 'Symfony\Component\Form\Extension\Core\Type\ColorType', $color);

$this->assertWidgetMatchesXpath($form->createView(), array('attr' => array('class' => 'my&class')),
'/input
[@type="color"]
[@name="name"]
[@class="my&class form-control"]
[@value="#0000ff"]
'
);
}
}
0