10000 [Process] Fix incorrectly calling PHP process when path contains space by maryo · Pull Request #22613 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Process] Fix incorrectly calling PHP process when path contains space #22613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2017
Merged

[Process] Fix incorrectly calling PHP process when path contains space #22613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix incorrectly calling PHP process on Windows when path contains space
  • Loading branch information
@maryo
maryo committed May 3, 2017
commit 9c081097392cc0431632cb5a9f13357391c1dfac
4 changes: 2 additions & 2 deletions src/Symfony/Component/Process/PhpProcess.php
View file
Open in desktop
6727
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ class PhpProcess extends Process
public function __construct($script, $cwd = null, array $env = null, $timeout = 60, array $options = null)
{
$executableFinder = new PhpExecutableFinder();
if (false === $php = $executableFinder->find()) {
if (false === $php = $executableFinder->find(false)) {
$php = null;
} else {
$php = explode(' ', $php);
$php = array_merge(array($php), $executableFinder->findArguments());
}
if ('phpdbg' === PHP_SAPI) {
$file = tempnam(sys_get_temp_dir(), 'dbg');
Expand Down
0