-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Add some missing docs for the web server bundle #22607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
<info>php %command.full_name%</info> | ||
|
||
The server is run in the background and you can keep executing other commands. | ||
Execute <comment>server:stop</> tp stop it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to stop it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -38,6 +38,20 @@ protected function configure() | |||
new InputOption('filter', null, InputOption::VALUE_REQUIRED, 'The value to display (one of port, host, or address)'), | |||
)) | |||
->setDescription('Outputs the status of the local web server for the given address') | |||
->setHelp(<<<'EOF' | |||
<info>%command.name%</info> shows the details of the given local web | |||
server, such as the address and port where is listening to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's listening to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
||
<info>php %command.full_name% --filter=port</info> | ||
|
||
Supported values are <comment>port</>, <comment>host</>, and <comment>address</>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's wrong actually. filter
is about filtering logs with the ExpressionLanguage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad copy/paste, fixed
This PR was merged into the 3.3-dev branch. Discussion ---------- Add some missing docs for the web server bundle | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This is an alternative to #22471 Commits ------- 987a681 added some missing docs for the web server bundle
<comment>--filter</> option: | ||
|
||
<info>php %command.full_name% --filter=port</info> | ||
EOF | ||
; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing )
fixed in #22626
This is an alternative to #22471