8000 Extract method refactoring for ResourceCheckerConfigCache by mpdude · Pull Request #22589 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Extract method refactoring for ResourceCheckerConfigCache #22589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Extract method refactoring for ResourceCheckerConfigCache #22589

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d67c8f6
Extract method refactoring for ResourceCheckerConfigCache
mpdude Apr 30, 2017
3ee1b2c
Remove useless statement
mpdude May 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 32 additions & 22 deletions src/Symfony/Component/Config/ResourceCheckerConfigCache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,37 +73,19 @@ public function isFresh()
}

$metadata = $this->getMetaFile();

if (!is_file($metadata)) {
return false;
}

$e = null;
$meta = false;
$time = filemtime($this->file);
$signalingException = new \UnexpectedValueException();
$prevUnserializeHandler = ini_set('unserialize_callback_func', '');
$prevErrorHandler = set_error_handler(function ($type, $msg, $file, $line, $context) use (&$prevErrorHandler, $signalingException) {
if (E_WARNING === $type && 'Class __PHP_Incomplete_Class has no unserializer' === $msg) {
throw $signalingException;
}

return $prevErrorHandler ? $prevErrorHandler($type, $msg, $file, $line, $context) : false;
});
$meta = $this->safelyUnserialize($metadata);

try {
$meta = unserialize(file_get_contents($metadata));
} catch (\Error $e) {
} catch (\Exception $e) {
}
restore_error_handler();
ini_set('unserialize_callback_func', $prevUnserializeHandler);
if (null !== $e && $e !== $signalingException) {
throw $e;
}
if (false === $meta) {
return false;
}

$time = filemtime($this->file);

foreach ($meta as $resource) {
/* @var ResourceInterface $resource */
foreach ($this->resourceCheckers as $checker) {
Expand Down Expand Up @@ -161,4 +143,32 @@ private function getMetaFile()
{
return $this->file.'.meta';
}

private function safelyUnserialize($file)
{
$e = null;
$meta = false;
$signalingException = new \UnexpectedValueException();
$prevUnserializeHandler = ini_set('unserialize_callback_func', '');
$prevErrorHandler = set_error_handler(function ($type, $msg, $file, $line, $context) use (&$prevErrorHandler, $signalingException) {
if (E_WARNING === $type && 'Class __PHP_Incomplete_Class has no unserializer' === $msg) { 6568
throw $signalingException;
}

return $prevErrorHandler ? $prevErrorHandler($type, $msg, $file, $line, $context) : false;
});

try {
$meta = unserialize(file_get_contents($file));
} catch (\Error $e) {
} catch (\Exception $e) {
}
restore_error_handler();
ini_set('unserialize_callback_func', $prevUnserializeHandler);
if (null !== $e && $e !== $signalingException) {
throw $e;
}

return $meta;
}
}
0