[VarDumper] Minor tweaks to html/css dumps #22455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrobat
reviewed
Apr 18, 2017
| @@ -496,7 +496,7 @@ protected function style($style, $value, $attr = array()) | |||
| $attr['href'] = $href; | |||
| } | |||
| if (isset($attr['href'])) { | |||
| $v = sprintf('<a href="%s">%s</a>', esc($this->utf8Encode($attr['href'])), $v); | |||
| $v = sprintf('<a href="%s" target="_blank">%s</a>', esc($this->utf8Encode($attr['href'])), $v); | |||
There was a problem hiding this comment.
Maybe it's good to also add the rel="noopener noreferrer" attribute to avoid security issues? See https://medium.com/@jitbit/target-blank-the-most-underestimated-vulnerability-ever-96e328301f4c
135bf9e to
3b83fe1
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Apr 18, 2017
This PR was merged into the 3.2 branch. Discussion ---------- [VarDumper] Minor tweaks to html/css dumps | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes (minor/DX) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 3b83fe1 [VarDumper] Minor tweaks to html/css dumps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.