8000 [Proposal][WIP][TwigBundle] Extract error handling into separate ErrorPageBundle by sustmi · Pull Request #22450 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Proposal][WIP][TwigBundle] Extract error handling into separate ErrorPageBundle #22450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[Proposal][WIP][TwigBundle] Extract error handling into separate ErrorPageBundle #22450

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
164d94c
[TwigBundle] Separate error pages into new ErrorPageBundle
sustmi Apr 15, 2017
1159c6a
fix TwigExtensionTest
sustmi Apr 15, 2017
f725b4c
rename services and parameters
sustmi Apr 15, 2017
e37307a
update changelogs
sustmi Apr 15, 2017
726602c
fix references to templates from WebProfilerBundle
sustmi Apr 15, 2017
e803a54
add dev dependency on symfony/error-page-bundle to symfony/security-b…
sustmi Apr 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix references to templates from WebProfilerBundle
  • Loading branch information
@sustmi
sustmi committed Apr 15, 2017
commit 726602c24001437880e4d36e9c58b09a9186bf19
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/WebProfilerBundle/Controller/ExceptionController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public function cssAction($token)

protected function getTemplate()
{
return '@Twig/Exception/'.($this->debug ? 'exception' : 'error').'.html.twig';
return '@ErrorPage/Exception/'.($this->debug ? 'exception' : 'error').'.html.twig';
}

// to be removed when the minimum required version of Twig is >= 2.0
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_redirect.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{% extends '@Twig/layout.html.twig' %}
{% extends '@ErrorPage/layout.html.twig' %}

{% block title 'Redirection Intercepted' %}

Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Bundle/WebProfilerBundle/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
],
"require": {
"php": ">=5.5.9",
"symfony/error-page-bundle": "dev-master",
"symfony/http-kernel": "~3.2",
"symfony/polyfill-php70": "~1.0",
"symfony/routing": "~2.8|~3.0",
Expand Down
0