10000 [Security] Allow to set a check_path on json_login listener by chalasr · Pull Request #22425 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] Allow to set a check_path on json_login listener #22425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Security] Allow to set a check_path on json_login listener #22425

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e6c261
Add check_path option to json_login listener
chalasr Apr 13, 2017
e4533f8
Flag the json_login listener as experimental
chalasr Apr 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Flag the json_login listener as experimental
  • Loading branch information
@chalasr
chalasr committed Apr 15, 2017
commit e4533f83e7faa4e54e960837f51b30596af193af
2 changes: 2 additions & 0 deletions src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/JsonLoginFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
* JsonLoginFactory creates services for JSON login authentication.
*
* @author Kévin Dunglas <dunglas@gmail.com>
*
* @experimental in version 3.3
*/
class JsonLoginFactory extends AbstractFactory
{
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/Security/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ CHANGELOG

* deprecated `AccessDecisionManager::setVoters()` in favor of passing the
voters to the constructor.
* [EXPERIMENTAL] added a `json_login` listener for stateless authentication

3.2.0
-----
Expand Down
2 changes: 2 additions & 0 deletions src/Symfony/Component/Security/Http/Firewall/UsernamePasswordJsonAuthenticationListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
* an authentication via a JSON document composed of a username and a password.
*
* @author Kévin Dunglas <dunglas@gmail.com>
*
* @experimental in version 3.3
*/
class UsernamePasswordJsonAuthenticationListener implements ListenerInterface
{
Expand Down
2 changes: 1 addition & 1 deletion ...Component/Security/Http/Tests/Firewall/UsernamePasswordJsonAuthenticationListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,6 @@ public function testAttemptAuthenticationIfRequestPathMatchesCheckPath()
$event = new GetResponseEvent($this->getMockBuilder(KernelInterface::class)->getMock(), $request, KernelInterface::MASTER_REQUEST);

$this->listener->handle($event);
$this->assertEquals('ok', $event->getResponse()->getContent());
$this->assertSame('ok', $event->getResponse()->getContent());
}
}
0