8000 [Debug] Set exit status to 255 on error by nicolas-grekas · Pull Request #22424 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Debug] Set exit status to 255 on error #22424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2017
Merged

[Debug] Set exit status to 255 on error #22424

merged 1 commit into from
Apr 13, 2017

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes (no easily testable in fact)
Fixed tickets #20775
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Apr 13, 2017
@nicolas-grekas nicolas-grekas force-pushed the debug-exit branch 2 times, most recently from e391b7c to be0bee1 Compare April 13, 2017 1 8000 7:54
tadcka
tadcka reviewed Apr 13, 2017
View reviewed changes
src/Symfony/Component/Debug/ErrorHandler.php
@@ -477,6 +478,9 @@ public function handleError($type, $message, $file, $line)
*/
public function handleException($exception, array $error = null)
{
if (null === $error) {
self::$exitCode = 255;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe better use constant?

This was referenced Apr 13, 2017
Closed
Closed
@chalasr
Copy link
Member
chalasr commented Apr 13, 2017

👍 I confirm it fixes it. Thanks!
Status: reviewed

@fabpot
Copy link
Member
fabpot commented Apr 13, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 67e249d into symfony:2.7 Apr 13, 2017
fabpot added a commit that referenced this pull request Apr 13, 2017
@fabpot
bug #22424 [Debug] Set exit status to 255 on error (nicolas-grekas)
5d83502 
This PR was merged into the 2.7 branch.

Discussion
----------

[Debug] Set exit status to 255 on error

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes (no easily testable in fact)
| Fixed tickets | #20775
| License       | MIT
| Doc PR        | -

Commits
-------

67e249d [Debug] Set exit status to 255 on error
@nicolas-grekas nicolas-grekas deleted the debug-exit branch April 14, 2017 06:05
@chalasr chalasr mentioned this pull request Apr 26, 2017
Closed
This was referenced May 1, 2017
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadcka tadcka tadcka left review comments

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @chalasr @fabpot @tadcka @carsonbot
0