8000 Dont call sprintf() when no placeholders are used by nicolas-grekas · Pull Request #22281 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Dont call sprintf() when no placeholders are used #22281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2017
Merged

Dont call sprintf() when no placeholders are used #22281

merged 1 commit into from
Apr 4, 2017

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Apr 4, 2017
javiereguiluz
javiereguiluz approved these changes Apr 4, 2017
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicolas-grekas nicolas-grekas merged commit 4951d3c into symfony:2.7 Apr 4, 2017
nicolas-grekas added a commit that referenced this pull request Apr 4, 2017
@nicolas-grekas
minor #22281 Dont call sprintf() when no placeholders are used (nicol…
405a1a4 
…as-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

Dont call sprintf() when no placeholders are used

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

4951d3c Dont call sprintf() when no placeholders are used
@nicolas-grekas nicolas-grekas deleted the cs branch April 4, 2017 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @javiereguiluz @carsonbot
0