[DI] Add "factory" support to named args and autowiring #22277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ca4e9d to
cf8ddbc
Compare
GuilhemN
reviewed
Apr 4, 2017
| * @param Definition $definition | ||
| * @param bool $required | ||
| * | ||
| * @return \ReflectionFunctionAbstract |
cf8ddbc to
27470de
Compare
GuilhemN
reviewed
Apr 4, 2017
| } elseif (null === $class) { | ||
| $class = $definition->getClass(); | ||
| } | ||
| if ('__construct' === $method) { |
There was a problem hiding this comment.
Does it really belong to this method? Shouldn't it be in CheckDefinitionValidityPass instead?
There was a problem hiding this comment.
this is required to prevent a potential infinite loop
There was a problem hiding this comment.
Ok, good point too :) It should still be added in CheckDefinitionValidityPass imo though.
| if ($constructor = $reflectionClass->getConstructor()) { | ||
| array_unshift($methodCalls, array($constructor->name, $value->getArguments())); | ||
| if ($constructor = $this->getConstructor($value, false)) { | ||
| array_unshift($methodCalls, array($constructor, $value->getArguments())); |
There was a problem hiding this comment.
Can't we keep ->name to remove the dedicated case, line 183 (https://github.com/symfony/symfony/pull/22277/files#diff-62df969ae028c559d33ffd256de1ac49R183)?
There was a problem hiding this comment.
nope we can't, because when a factory is used, a simple string is not enough to reference the target
GuilhemN
approved these changes
Apr 4, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 4, 2017
…g (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Add "factory" support to named args and autowiring | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - To me, factories are expected to work named arguments. Doing so also unlocks supporting them when autowiring, and will benefit #22187 soon. Commits ------- 27470de [DI] Add "factory" support to named args and autowiring
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To me, factories are expected to work named arguments.
Doing so also unlocks supporting them when autowiring, and will benefit #22187 soon.