8000 [Translation] avoid creating cache files for fallback locales. by aitboudad · Pull Request #22255 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Translation] avoid creating cache files for fallback locales. #22255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2017
Merged

[Translation] avoid creating cache files for fallback locales. #22255

merged 1 commit into from
Apr 5, 2017

Conversation

aitboudad
Copy link
Contributor
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #21163
License MIT
Doc PR ~

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Apr 4, 2017
@nicolas-grekas
Copy link
Member

Could you add a test please?

nicolas-grekas
nicolas-grekas approved these changes Apr 5, 2017
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fabpot
Copy link
Member
fabpot commented Apr 5, 2017

Thank you @aitboudad.

@fabpot fabpot merged commit 22425b2 into symfony:2.7 Apr 5, 2017
9957
fabpot added a commit that referenced this pull request Apr 5, 2017
@fabpot
bug #22255 [Translation] avoid creating cache files for fallback loca…
a200357 
…les. (aitboudad)

This PR was merged into the 2.7 branch.

Discussion
----------

[Translation] avoid creating cache files for fallback locales.

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21163
| License       | MIT
| Doc PR        | ~

Commits
-------

22425b2 [Translation] avoid creating cache files for fallback locales.
@aitboudad aitboudad deleted the issue_21163 branch April 5, 2017 14:57
This was referenced May 1, 2017
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@aitboudad @nicolas-grekas @fabpot
0