[Component] [Yaml] [Parser] : can parse with trailing space as 2.8 #22216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
requested changes
Mar 29, 2017
| $yaml = <<<YAML | ||
| items: | ||
| foo: bar | ||
| YAML; |
There was a problem hiding this comment.
We should write the fixture this way: $yaml = "items: \n foo: bar";. Otherwise, someone will save the test file with an editor that strips trailing whitespace which will make the test pretty useless.
| 'items' => array('foo' => 'bar'), | ||
| ); | ||
|
|
||
| $this->assertEquals($expected, $this->parser->parse($yaml)); |
|
@xabbuh good catch, I did the modifications |
|
Thank you @jordscream. |
fabpot
added a commit
that referenced
this pull request
Mar 31, 2017
…e as 2.8 (jordscream) This PR was merged into the 3.3-dev branch. Discussion ---------- [Component] [Yaml] [Parser] : can parse with trailing space as 2.8 | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #22193 | License | MIT | Doc PR | symfony/symfony-docs Missing rtrim method in line to parse as the version 2.8 does Commits ------- ce3d5ab [Component] [Yaml] [Parser] : can parse with trailing space as 2.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing rtrim method in line to parse as the version 2.8 does