8000 [FrameworkBundle] Multiple services on one Command class by fabpot · Pull Request #22120 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Multiple services on one Command class #22120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[FrameworkBundle] Multiple services on one Command class #22120

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1c1778d
Append service id to alias if it already exists
SenseException Jul 3, 2016
12e6edb
Add test to cover multiple services with one command class
SenseException Jul 6, 2016
85ac7b4
Add test to cover multiple services with one command class
SenseException Jul 6, 2016
4c91f5e
Fix of coding styles
SenseException Jul 6, 2016
cd33405
Remove usage of setParameter for command class
SenseException Jul 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test to cover multiple services with one command class
  • Loading branch information
@SenseException @fabpot
SenseException authored and fabpot committed Mar 22, 2017
commit 85ac7b492d7a31bc322cd39b20fe14cfe0b0e8f1
23 changes: 23 additions & 0 deletions ...y/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/AddConsoleCommandPassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,29 @@ public function testProcessServicesWithSameCommand()
$this->assertTrue($container->hasAlias($alias1));
$this->assertTrue($container->hasAlias($alias2));
}

public function testProcessServicesWithSameCommand()
{
$container = new ContainerBuilder();
$container->addCompilerPass(new AddConsoleCommandPass());
$container->setParameter('my-command.class', 'Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection\Compiler\MyCommand');

$definition1 = new Definition('%my-command.class%');
$definition1->addTag('console.command');

$definition2 = new Definition('%my-command.class%');
$definition2->addTag('console.command');

$container->setDefinition('my-command1', $definition1);
$container->setDefinition('my-command2', $definition2);

$container->compile();

$alias1 = 'console.command.symfony_bundle_frameworkbundle_tests_dependencyinjection_compiler_mycommand';
$alias2 = $alias1 . '_my-command2';
$this->assertTrue($container->hasAlias($alias1));
$this->assertTrue($container->hasAlias($alias2));
}
}

class MyCommand extends Command
Expand Down
0