[Security] simplify the SwitchUserListenerTest #22049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuilhemN
reviewed
Mar 18, 2017
|
|
||
| $this->tokenStorage->expects($this->any())->method('getToken')->will($this->returnValue($token)); | ||
| $this->request->expects($this->any())->method('get')->with('_switch_user')->will($this->returnValue('kuba')); | ||
| $this->request->query->expects($this->once())->method('remove', '_switch_user'); |
There was a problem hiding this comment.
isn't this missing in the new test?
There was a problem hiding this comment.
We check later on that the query parameter bag is empty.
GuilhemN
approved these changes
Mar 18, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Mar 22, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [Security] simplify the SwitchUserListenerTest | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | While working on #22048 I noticed that the `SwitchUserListenerTest` was more complicated than necessary by mocking a lot of stuff that didn't need to be mocked. Commits ------- 923bbdb [Security] simplify the SwitchUserListenerTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #22048 I noticed that the
SwitchUserListenerTestwas more complicated than necessary by mocking a lot of stuff that didn't need to be mocked.