8000 Deprecate the special SYMFONY__ environment variables by javiereguiluz · Pull Request #21889 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Deprecate the special SYMFONY__ environment variables #21889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Deprecate the special SYMFONY__ environment variables #21889

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2b8b6c7
Deprecate the special SYMFONY__ environment variables
javiereguiluz Mar 6, 2017
4374128
Deprecated the entire getEnvParameters() method
javiereguiluz Mar 14, 2017
924e18c
Added UPGRADE and CHANGELOG info
javiereguiluz Mar 14, 2017
1c08baa
Minor improvement
javiereguiluz Mar 19, 2017
a1ba61d
Fixed the tested deprecation message
javiereguiluz Mar 20, 2017
247d17e
Don't use deprecated features in tests
javiereguiluz Mar 20, 2017
9e99d7b
Removed unneeded code
javiereguiluz Mar 20, 2017
d9e2375
Define a default value for REDIS_HOST parameter
javiereguiluz Mar 20, 2017
b55f181
Fixed another failing test config
javiereguiluz Mar 21, 2017
3ed6d2f
Unset the env var after the test is finished
javiereguiluz Mar 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't use deprecated features in tests
  • Loading branch information
@javiereguiluz
javiereguiluz committed Mar 20, 2017
commit 247d17e1772c04eafa20d21c1ed6a52a283356b5
4 changes: 2 additions & 2 deletions src/Symfony/Bundle/FrameworkBundle/Tests/Functional/CachePoolsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ class CachePoolsTest extends WebTestCase
{
protected function setUp()
{
$_SERVER['SYMFONY__REDIS_HOST'] = getenv('REDIS_HOST');
$_SERVER['REDIS_HOST'] = getenv('REDIS_HOST');
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems unnecessary

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure. Can I remove both setUp() and tearDown() ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say yes


protected function tearDown()
{
unset($_SERVER['SYMFONY__REDIS_HOST']);
unset($_SERVER['REDIS_HOST']);
}

public function testCachePools()
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/FrameworkBundle/Tests/Functional/app/CachePools/redis_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ imports:
framework:
cache:
app: cache.adapter.redis
default_redis_provider: "redis://%redis_host%"
default_redis_provider: "redis://%env(REDIS_HOST)%"
pools:
cache.pool1:
public: true
Expand Down
0