8000 [DI] Replace PHP7-conditional return-type checks by regular type-hints that work on PHP5 by nicolas-grekas · Pull Request #21888 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DI] Replace PHP7-conditional return-type checks by regular type-hints that work on PHP5 #21888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2017
Merged

[DI] Replace PHP7-conditional return-type checks by regular type-hints that work on PHP5 #21888

merged 1 commit into from
Mar 6, 2017

Conversation

nicolas-grekas
Copy link
Member
@nicolas-grekas nicolas-grekas commented Mar 6, 2017 •
edited
Loading
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Mar 6, 2017
@nicolas-grekas nicolas-grekas changed the title [DI] Replace PHP7-conditional return-type checks by regular type-hint… [DI] Replace PHP7-conditional return-type checks by regular type-hints that work on PHP5 Mar 6, 2017
javiereguiluz
javiereguiluz approved these changes Mar 6, 2017
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicolas-grekas nicolas-grekas merged commit 372ff7c into symfony:master Mar 6, 2017
nicolas-grekas added a commit that referenced this pull request Mar 6, 2017
@nicolas-grekas
minor #21888 [DI] Replace PHP7-conditional return-type checks by regu…
e7c12d3 
…lar type-hints that work on PHP5 (nicolas-grekas)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[DI] Replace PHP7-conditional return-type checks by regular type-hints that work on PHP5

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

372ff7c [DI] Replace PHP7-conditional return-type checks by regular type-hints that work on PHP5
@nicolas-grekas nicolas-grekas deleted the di-clean branch March 6, 2017 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @javiereguiluz @carsonbot
0