Fix symlinks on Windows. #21887
Closed
Fix symlinks on Windows. #21887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #18324 for some background on the topic. |
| $ok = @symlink($originDir, $targetDir); | ||
| } | ||
|
|
||
| if (!$ok && strncasecmp(PHP_OS, 'WIN', 3) == 0) { |
There was a problem hiding this comment.
Minor comment: to detect if the OS is macOS, we use the PHP_OS constant as follows: 'Darwin' === PHP_OS But for Windows, we always use this indirect detection: '\\' === DIRECTORY_SEPARATOR
|
Closing as it cannot be merged as is. Feel free to reopen if you think you can finish it by taking #18324 into consideration. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Php's symlink function on Windows is completely broken, see:
php/php-src#1243
https://bugs.php.net/bug.php?id=69473
Looks like there is little to no intention to fix this in core. An alternative way to achieve symlinks (properly) on Windows is to use the command line.
I submitted a similar PR for the composer/composer project, where they use symfony's filesystem + a manual junction based fallback for windows:
composer/composer#6213
This patch adds additional fallback to try and create the symlink on windows environments using exec()