[DI] Fix ServiceLocatorArgument::setValues() for non-reference values #21794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, we should still allow only |
d23c60c to
2535108
Compare
|
@stof fixed |
| @@ -39,7 +39,7 @@ public function getValues() | |||
| public function setValues(array $values) | |||
| { | |||
| foreach ($values as $v) { | |||
| if (!$v instanceof Reference) { | |||
| if (!$v instanceof Reference && null !== $v) { | |||
There was a problem hiding this comment.
nulls will create services that have "has()" return true, and "get()" return null. Not sure it's useful at all. What about skipping them instead?
There was a problem hiding this comment.
Self answer: bad idea: maybe the consumer expects a value from get for the provided key. :)
Test case missing?
b71b4db to
ae18b79
Compare
ae18b79 to
256b836
Compare
|
Build failure unrelated. |
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 28, 2017
…ence values (chalasr) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Fix ServiceLocatorArgument::setValues() for non-reference values | Q | A | ------------- | --- | Branch? | master | Fixed tickets | #21625 (comment) | Tests pass? | yes | License | MIT `ResolveInvalidReferencesPass` [calls `setValues()`](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DependencyInjection/Compiler/ResolveInvalidReferencesPass.php#L91) with resolved invalid reference (null), the `Reference` type check should occurs at construction only. Commits ------- 256b836 [DI] Fix ServiceLocatorArgument::setValues() for non-reference values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResolveInvalidReferencesPasscallssetValues()with resolved invalid reference (null), theReferencetype check should occurs at construction only.