8000 [Config] fixed glob file loader when there is an exception by fabpot · Pull Request #21736 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Config] fixed glob file loader when there is an exception #21736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2017

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Feb 23, 2017
Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Fixes a typo. When importing a glob, we definitely want to have errors like syntax errors in a YAML file.

@fabpot fabpot force-pushed the glob-file-loader-fix branch from cd0063c to d1b6601 Compare February 23, 2017 16:37
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fabpot fabpot merged commit d1b6601 into symfony:master Feb 23, 2017
fabpot added a commit that referenced this pull request Feb 23, 2017
… (fabpot)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[Config] fixed glob file loader when there is an exception

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Fixes a typo. When importing a glob, we definitely want to have errors like syntax errors in a YAML file.

Commits
-------

d1b6601 [Config] fixed glob file loader when there is an exception
@fabpot fabpot deleted the glob-file-loader-fix branch April 7, 2017 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0