Fix emacs link #21731
Merged
Fix emacs link #21731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Applies to 2.7, isn't it? |
|
Yes, new pull request? |
|
@rubenrua No need for a new PR. You can rebase your changes onto the |
When an Emacs buffer is modified, by default Emacs automatically creates a temporary symlink in the same directory as the file being edited (e.g. Controller.php): ``` .#Controller.php -> user@host.12345:1296583136 ``` where '12345' is Emacs' PID. In this case Symfony breaks with a RuntimeException: ``` SplFileInfo::getMTime(): stat failed for ...Bundle/Controller/.#APIController.php ``` in vendor/symfony/symfony/src/Symfony/Component/Config/Resource/DirectoryResource.php at line 89 ``` $newestMTime = max($file->getMTime(), $newestMTime); ```
7c01924 to
c6f7ca6
Compare
|
Rebase done |
fabpot
reviewed
Feb 28, 2017
| @@ -84,8 +84,15 @@ public function isFresh($timestamp) | |||
| continue; | |||
| } | |||
|
|
|||
| // for broken links | |||
| try { | |||
| $fileMTime = $file->getMTime(); | |||
There was a problem hiding this comment.
Does getMTime() from PHP throws a RuntimeException? If yes, since which version?
There was a problem hiding this comment.
All PHP versions since 5.3.
symlink('/tmp/target_not_exists', '/tmp/link');
$file = new SplFileInfo('/tmp/link');
var_dump($file->getMTime());|
Thank you @rubenrua. |
fabpot
added a commit
that referenced
this pull request
Mar 1, 2017
This PR was merged into the 2.7 branch. Discussion ---------- Fix emacs link | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes (minor) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | none When an Emacs buffer is modified, by default Emacs automatically creates a temporary symlink in the same directory as the file being edited (e.g. Controller.php): ``` .#Controller.php -> user@host.12345:1296583136 ``` where '12345' is [the Emacs' PID][1]. In this case Symfony breaks with a RuntimeException: ``` SplFileInfo::getMTime(): stat failed for ...Bundle/Controller/.#APIController.php ``` in vendor/symfony/symfony/src/Symfony/Component/Config/Resource/DirectoryResource.php at line 89 ``` $newestMTime = max($file->getMTime(), $newestMTime); ``` [1]: https://www.gnu.org/software/emacs/manual/html_node/emacs/Interlocking.html Commits ------- c6f7ca6 Fix RuntimeException when an Emacs buffer is modified
This was referenced Mar 6, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an Emacs buffer is modified, by default Emacs automatically creates a
temporary symlink in the same directory as the file being edited (e.g. Controller.php):
where '12345' is the Emacs' PID.
In this case Symfony breaks with a RuntimeException:
in
vendor/symfony/symfony/src/Symfony/Component/Config/Resource/DirectoryResource.php
at line 89