8000 [Yaml] fix DUMP_EMPTY_ARRAY_AS_SEQUENCE flag value by xabbuh · Pull Request #21678 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Yaml] fix DUMP_EMPTY_ARRAY_AS_SEQUENCE flag value #21678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2017
Merged

[Yaml] fix DUMP_EMPTY_ARRAY_AS_SEQUENCE flag value #21678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Yaml/Yaml.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class Yaml
const DUMP_OBJECT_AS_MAP = 64;
const DUMP_MULTI_LINE_LITERAL_BLOCK = 128;
const PARSE_CONSTANT = 256;
const DUMP_EMPTY_ARRAY_AS_SEQUENCE = 512;
const DUMP_EMPTY_ARRAY_AS_SEQUENCE = 1024;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about reversing DUMP_EMPTY_ARRAY_AS_SEQUENCE and PARSE_CUSTOM_TAGS values? It would look more natural imo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it's not worth it. Otherwise we begin to swap values every time we introduce new flags.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it an issue really?


/**
* @experimental in version 3.3
Expand Down
0