8000 [VarDumper] Added missing persistent stream cast by lyrixx · Pull Request #21634 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[VarDumper] Added missing persistent stream cast #21634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2017
Merged

[VarDumper] Added missing persistent stream cast #21634

merged 1 commit into from
Feb 16, 2017

Conversation

lyrixx
Copy link
Member
@lyrixx lyrixx commented Feb 16, 2017
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@lyrixx lyrixx force-pushed the vardumper-persist-conn branch from 0ead773 to cab9f7e Compare February 16, 2017 17:03
@lyrixx lyrixx changed the base branch from 2.8 to 2.7 February 16, 2017 17:03
nicolas-grekas
nicolas-grekas approved these changes Feb 16, 2017
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Feb 16, 2017
@fabpot
Copy link
Member
fabpot commented Feb 16, 2017

Thank you @lyrixx.

@fabpot fabpot merged commit cab9f7e into symfony:2.7 Feb 16, 2017
fabpot added a commit that referenced this pull request Feb 16, 2017
@fabpot
bug #21634 [VarDumper] Added missing persistent stream cast (lyrixx)
38490da 
This PR was merged into the 2.7 branch.

Discussion
----------

[VarDumper] Added missing persistent stream cast

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

cab9f7e [VarDumper] Added missing persistent stream cast
@lyrixx lyrixx deleted the vardumper-persist-conn branch February 16, 2017 20:11
@fabpot fabpot mentioned this pull request Feb 17, 2017
Merged
This was referenced Mar 6, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Status: Needs Review VarDumper
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@lyrixx @fabpot @nicolas-grekas @carsonbot
0