[Security] LdapUserProvider should not throw an exception if the UID key does not exist in an LDAP entry #21579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t exist in the response
|
Tests are not yet added, I will add them a bit later. |
|
Added tests. Failures are not related to this PR. |
|
Ping @nicolas-grekas |
|
merging into 3.2 as 3.1 is not maintained anymore. |
|
Thank you @csarrazi. |
fabpot
added a commit
that referenced
this pull request
Feb 11, 2017
…if the UID key does not exist in an LDAP entry (csarrazi) This PR was submitted for the 3.1 branch but it was merged into the 3.2 branch instead (closes #215 7DF5 79). Discussion ---------- [Security] LdapUserProvider should not throw an exception if the UID key does not exist in an LDAP entry | Q | A | ------------- | --- | Branch? | 3.1+ | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21577 | License | MIT | Doc PR | This ticket should fix #21577, which was introduced by commit 6641b79 LdapUserProvider should not throw an exception if the uid key does not exist in the entry. Commits ------- ee4d9a7 [Security] LdapUserProvider should not throw an exception if the UID key does not exist in an LDAP entry
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket should fix #21577, which was introduced by commit 6641b79
LdapUserProvider should not throw an exception if the uid key does not exist in the entry.