-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Translation] Added a lint:xliff command for XLIFF files #21578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d4ae5bf
[Translation] Added a lint:translation command for XLIFF files
javiereguiluz b64b3d9
Fixed the issues pointed out by reviewers
javiereguiluz fcae25e
Renamed "lint:translation" to "lint:xliff"
javiereguiluz 55bd4b6
Use a Yoda condition
javiereguiluz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
80 changes: 80 additions & 0 deletions
80
src/Symfony/Bundle/FrameworkBundle/Command/XliffLintCommand.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Bundle\FrameworkBundle\Command; | ||
|
||
use Symfony\Component\Console\Command\Command; | ||
use Symfony\Component\Console\Input\InputInterface; | ||
use Symfony\Component\Console\Output\OutputInterface; | ||
use Symfony\Component\Translation\Command\XliffLintCommand as BaseLintCommand; | ||
|
||
/** | ||
* Validates XLIFF files syntax and outputs encountered errors. | ||
* | ||
* @author Grégoire Pineau <lyrixx@lyrixx.info> | ||
* @author Robin Chalas <robin.chalas@gmail.com> | ||
* @author Javier Eguiluz <javier.eguiluz@gmail.com> | ||
*/ | ||
class XliffLintCommand extends Command | ||
{ | ||
private $command; | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
protected function configure() | ||
{ | ||
$this->setName('lint:xliff'); | ||
|
||
if (!$this->isEnabled()) { | ||
return; | ||
} | ||
|
||
$directoryIteratorProvider = function ($directory, $default) { | ||
if (!is_dir($directory)) { | ||
$directory = $this->getApplication()->getKernel()->locateResource($directory); | ||
} | ||
|
||
return $default($directory); | ||
}; | ||
|
||
$isReadableProvider = function ($fileOrDirectory, $default) { | ||
return 0 === strpos($fileOrDirectory, '@') || $default($fileOrDirectory); | ||
}; | ||
|
||
$this->command = new BaseLintCommand(null, $directoryIteratorProvider, $isReadableProvider); | ||
|
||
$this | ||
->setDescription($this->command->getDescription()) | ||
->setDefinition($this->command->getDefinition()) | ||
->setHelp($this->command->getHelp().<<<'EOF' | ||
|
||
Or find all files in a bundle: | ||
|
||
<info>php %command.full_name% @AcmeDemoBundle</info> | ||
|
||
EOF | ||
); | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function isEnabled() | ||
{ | ||
return class_exists(BaseLintCommand::class); | ||
} | ||
|
||
protected function execute(InputInterface $input, OutputInterface $output) | ||
{ | ||
return $this->command->execute($input, $output); | ||
} | ||
} |
254 changes: 254 additions & 0 deletions
254
src/Symfony/Component/Translation/Command/XliffLintCommand.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,254 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\Translation\Command; | ||
|
||
use Symfony\Component\Console\Command\Command; | ||
use Symfony\Component\Console\Input\InputInterface; | ||
use Symfony\Component\Console\Input\InputOption; | ||
use Symfony\Component\Console\Output\OutputInterface; | ||
use Symfony\Component\Console\Style\SymfonyStyle; | ||
|
||
/** | ||
* Validates XLIFF files syntax and outputs encountered errors. | ||
* | ||
* @author Grégoire Pineau <lyrixx@lyrixx.info> | ||
* @author Robin Chalas <robin.chalas@gmail.com> | ||
* @author Javier Eguiluz <javier.eguiluz@gmail.com> | ||
*/ | ||
class XliffLintCommand extends Command | ||
{ | ||
private $parser; | ||
private $format; | ||
private $displayCorrectFiles; | ||
private $directoryIteratorProvider; | ||
private $isReadableProvider; | ||
|
||
public function __construct($name = null, $directoryIteratorProvider = null, $isReadableProvider = null) | ||
{ | ||
parent::__construct($name); | ||
|
||
$this->directoryIteratorProvider = $directoryIteratorProvider; | ||
$this->isRe 8000 adableProvider = $isReadableProvider; | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
protected function configure() | ||
{ | ||
$this | ||
->setName('lint:xliff') | ||
->setDescription('Lints a XLIFF file and outputs encountered errors') | ||
->addArgument('filename', null, 'A file or a directory or STDIN') | ||
->addOption('format', null, InputOption::VALUE_REQUIRED, 'The output format', 'txt') | ||
->setHelp(<<<EOF | ||
The <info>%command.name%</info> command lints a XLIFF file and outputs to STDOUT | ||
the first encountered syntax error. | ||
|
||
You can validates XLIFF contents passed from STDIN: | ||
|
||
<info>cat filename | php %command.full_name%</info> | ||
|
||
You can also validate the syntax of a file: | ||
|
||
<info>php %command.full_name% filename</info> | ||
|
||
Or of a whole directory: | ||
|
||
<info>php %command.full_name% dirname</info> | ||
<info>php %command.full_name% dirname --format=json</info> | ||
|
||
EOF | ||
) | ||
; | ||
} | ||
|
||
protected function execute(InputInterface $input, OutputInterface $output) | ||
{ | ||
$io = new SymfonyStyle($input, $output); | ||
$filename = $input->getArgument('filename'); | ||
$this->format = $input->getOption('format'); | ||
$this->displayCorrectFiles = $output->isVerbose(); | ||
|
||
if (!$filename) { | ||
if (!$stdin = $this->getStdin()) { | ||
throw new \RuntimeException('Please provide a filename or pipe file content to STDIN.'); | ||
} | ||
|
||
return $this->display($io, array($this->validate($stdin))); | ||
} | ||
|
||
if (!$this->isReadable($filename)) { | ||
throw new \RuntimeException(sprintf('File or directory "%s" is not readable.', $filename)); | ||
} | ||
|
||
$filesInfo = array(); | ||
foreach ($this->getFiles($filename) as $file) { | ||
$filesInfo[] = $this->validate(file_get_contents($file), $file); | ||
} | ||
|
||
return $t 8000 his->display($io, $filesInfo); | ||
} | ||
|
||
private function validate($content, $file = null) | ||
{ | ||
// Avoid: Warning DOMDocument::loadXML(): Empty string supplied as input | ||
if ('' === trim($content)) { | ||
return array('file' => $file, 'valid' => true); | ||
} | ||
|
||
libxml_use_internal_errors(true); | ||
|
||
$document = new \DOMDocument(); | ||
$document->loadXML($content); | ||
if ($document->schemaValidate(__DIR__.'/../Resources/schemas/xliff-core-1.2-strict.xsd')) { | ||
return array('file' => $file, 'valid' => true); | ||
} | ||
|
||
$errorMessages = array_map(function ($error) { | ||
return array( | ||
'line' => $error->line, | ||
'column' => $error->column, | ||
'message' => trim($error->message), | ||
); | ||
}, libxml_get_errors()); | ||
|
||
libxml_clear_errors(); | ||
libxml_use_internal_errors(false); | ||
|
||
return array('file' => $file, 'valid' => false, 'messages' => $errorMessages); | ||
} | ||
|
||
private function display(SymfonyStyle $io, array $files) | ||
{ | ||
switch ($this->format) { | ||
case 'txt': | ||
return $this->displayTxt($io, $files); | ||
case 'json': | ||
return $this->displayJson($io, $files); | ||
default: | ||
throw new \InvalidArgumentException(sprintf('The format "%s" is not supported.', $this->format)); | ||
} | ||
} | ||
|
||
private function displayTxt(SymfonyStyle $io, array $filesInfo) | ||
{ | ||
$countFiles = count($filesInfo); | ||
$erroredFiles = 0; | ||
|
||
foreach ($filesInfo as $info) { | ||
if ($info['valid'] && $this->displayCorrectFiles) { | ||
$io->comment('<info>OK</info>'.($info['file'] ? sprintf(' in %s', $info['file']) : '')); | ||
} elseif (!$info['valid']) { | ||
++$erroredFiles; | ||
$io->text('<error> ERROR </error>'.($info['file'] ? sprintf(' in %s', $info['file']) : '')); | ||
$io->listing(array_map(function ($error) { | ||
// general document errors have a '-1' line number | ||
return -1 === $error['line'] ? $error['message'] : sprintf('Line %d, Column %d: %s', $error['line'], $error['column'], $error['message']); | ||
}, $info['messages'])); | ||
} | ||
} | ||
|
||
if (0 === $erroredFiles) { | ||
$io->success(sprintf('All %d XLIFF files contain valid syntax.', $countFiles)); | ||
} else { | ||
$io->warning(sprintf('%d XLIFF files have valid syntax and %d contain errors.', $countFiles - $erroredFiles, $erroredFiles)); | ||
} | ||
|
||
return min($erroredFiles, 1); | ||
} | ||
|
||
private function displayJson(SymfonyStyle $io, array $filesInfo) | ||
{ | ||
$errors = 0; | ||
|
||
array_walk($filesInfo, function (&$v) use (&$errors) { | ||
$v['file'] = (string) $v['file']; | ||
if (!$v['valid']) { | ||
++$errors; | ||
} | ||
}); | ||
|
||
$io->writeln(json_encode($filesInfo, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES)); | ||
|
||
return min($errors, 1); | ||
} | ||
|
||
private function getFiles($fileOrDirectory) | ||
{ | ||
if (is_file($fileOrDirectory)) { | ||
yield new \SplFileInfo($fileOrDirectory); | ||
|
||
return; | ||
} | ||
|
||
foreach ($this->getDirectoryIterator($fileOrDirectory) as $file) { | ||
if (!in_array($file->getExtension(), array('xlf', 'xliff'))) { | ||
continue; | ||
} | ||
|
||
yield $file; | ||
} | ||
} | ||
|
||
private function getStdin() | ||
{ | ||
if (0 !== ftell(STDIN)) { | ||
return; | ||
} | ||
|
||
$inputs = ''; | ||
while (!feof(STDIN)) { | ||
$inputs .= fread(STDIN, 1024); | ||
} | ||
|
||
return $inputs; | ||
} | ||
|
||
private function getParser() | ||
{ | ||
if (!$this->parser) { | ||
$this->parser = new Parser(); | ||
} | ||
|
||
return $this->parser; | ||
} | ||
|
||
private function getDirectoryIterator($directory) | ||
{ | ||
$default = function ($directory) { | ||
return new \RecursiveIteratorIterator( | ||
new \RecursiveDirectoryIterator($directory, \FilesystemIterator::SKIP_DOTS | \FilesystemIterator::FOLLOW_SYMLINKS), | ||
\RecursiveIteratorIterator::LEAVES_ONLY | ||
); | ||
}; | ||
|
||
if (null !== $this->directoryIteratorProvider) { | ||
return call_user_func($this->directoryIteratorProvider, $directory, $default); | ||
} | ||
|
||
return $default($directory); | ||
} | ||
|
||
private function isReadable($fileOrDirectory) | ||
{ | ||
$default = function ($fileOrDirectory) { | ||
return is_readable($fileOrDirectory); | ||
}; | ||
|
||
if (null !== $this->isReadableProvider) { | ||
return call_user_func($this->isReadableProvider, $fileOrDirectory, $default); | ||
} | ||
|
||
return $default($fileOrDirectory); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If "-1" will be not allowed as line number, "%u" is more suitable as type specifier. The same applies for column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, the
-1
value is not used ... but this could change at any moment, so let's keep it safe with the%d
syntax.