8000 [WIP] Annotation support for Services by weaverryan · Pull Request #21376 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WIP] Annotation support for Services #21376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[WIP] Annotation support for Services #21376

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3154e12
[WIP] Initial system for adding DI annotation support to classes
weaverryan Jan 23, 2017
f679a2a
Thanks fabbot!
weaverryan Jan 23, 2017
5296f01
Fixing my reversed logic!
weaverryan Jan 23, 2017
c6ac896
Simply using the internal index, which is equal
weaverryan Jan 23, 2017
f3da69a
Adding strict checking, and clear error handling
weaverryan Jan 23, 2017
ace5106
Thanks fabbot!
weaverryan Jan 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simply using the internal index, which is equal
  • Loading branch information
@weaverryan
weaverryan committed Jan 23, 2017
commit c6ac8962ccf9d9325f6a919b6e7ad7cf4a3df7f2
5 changes: 1 addition & 4 deletions src/Symfony/Component/DependencyInjection/Compiler/ServiceAnnotationsPass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,8 @@ private function getArgumentAnnotationsForMethod(\ReflectionMethod $method)
private function getMethodArguments(\ReflectionMethod $method)
{
$arguments = array();
$i = 0;
foreach ($method->getParameters() as $parameter) {
foreach ($method->getParameters() as $i => $parameter) {
$arguments[$parameter->getName()] = $i;

++$i;
}

return $arguments;
Expand Down
0