-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DependencyInjection] ActionBundle integration: introduce _instanceof #21357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
0a48b9e
9b9dbea
14e85c6
4e0b1e5
ec9c5b2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -221,6 +221,7 @@ private function parseDefinition(\DOMElement $service, $file, array $defaults = | |
} | ||
|
||
if ($parentId) { | ||
$s = clone $s; | ||
$s->setAttribute('parent', $parentId); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is an issue here. This is altering the DOM node, which means it will impact the next services too (which will break things if they are not ChildDefinition themselves) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed. |
||
} | ||
$parentId = $this->generateInstanceofDefinitionId($id, $type, $file); | ||
|
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it throw an exception if there is already a parent?