8000 Ignore missing 'debug.file_link_formatter' service in Debug bundle by core23 · Pull Request #21292 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Ignore missing 'debug.file_link_formatter' service in Debug bundle #21292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2017
Merged

Ignore missing 'debug.file_link_formatter' service in Debug bundle #21292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Ignore missing 'debug.file_link_formatter' service in Debug bundle
  • Loading branch information
@core23
core23 committed Feb 6, 2017
commit 2201fbe28b5dce46d0642f4f05b11e6b868857bc
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/DebugBundle/Resources/config/services.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
<argument>0</argument> <!-- flags -->
<call method="setDisplayOptions">
<argument type="collection">
<argument key="fileLinkFormat" type="service" id="debug.file_link_formatter"></argument>
<argument key="fileLinkFormat" type="service" id="debug.file_link_formatter" on-invalid="ignore"></argument>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the service is invalid then the call still occurs with an empty collection as argument. I suggest to remove the call entirely and add it conditionally in DebugExtension instead

</argument>
</call>
</service>
Expand Down
0