8000 [Cache] Using strpbrk() instead of strcspn() is faster by nicolas-grekas · Pull Request #21269 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Cache] Using strpbrk() instead of strcspn() is faster #21269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2017
Merged

[Cache] Using strpbrk() instead of strcspn() is faster #21269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Symfony/Component/Cache/CacheItem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public function expiresAfter($time)
*
* @param string $key The key to validate
*
* @throws InvalidArgumentException When $key is not valid.
* @throws InvalidArgumentException When $key is not valid
*/
public static function validateKey($key)
{
Expand All @@ -111,7 +111,7 @@ public static function validateKey($key)
if (!isset($key[0])) {
throw new InvalidArgumentException('Cache key length must be greater than zero');
}
if (isset($key[strcspn($key, '{}()/\@:')])) {
if (false !== strpbrk($key, '{}()/\@:')) {
throw new InvalidArgumentException(sprintf('Cache key "%s" contains reserved characters {}()/\@:', $key));
}
}
Expand Down
0