10000 [Form] Fix ChoiceType to ensure submitted data is not nested unnecessarily by issei-m · Pull Request #21267 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Fix ChoiceType to ensure submitted data is not nested unnecessarily #21267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

[Form] Fix ChoiceType to ensure submitted data is not nested unnecessarily #21267

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cd7d2a4
[Form] Simplify FQCN in ChoiceTypeTest
issei-m Jan 13, 2017
fb33ad2
[Form] Add failure test case to ChoiceTypeTest for invalid nested value
issei-m Jan 13, 2017
98195dd
[Form] Fix ChoiceType to ensure submitted data is not nested unnecess…
issei-m Jan 13, 2017
9d406db
Fix CS
issei-m Jan 13, 2017
61c80c2
[Form] Fix validation-listener logic and move block to the end-of-method
issei-m Jan 19, 2017
eb4d85a
Update comment
issei-m Feb 9, 2017
d6d2db5
Move test data provider after the test method
issei-m Feb 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comment
  • Loading branch information
@issei-m
issei-m committed Feb 9, 2017
commit eb4d85a0ed0dc52c389f733f6eda367e05a13850
4 changes: 2 additions & 2 deletions src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ public function buildForm(FormBuilderInterface $builder, array $options)
$builder->addEventSubscriber(new MergeCollectionListener(true, true));
}

// To avoid some problem against treating of array (e.g. Array to string conversion),
// we have to first ensure the all elements of submitted data ain't an array.
// To avoid issues when the submitted choices are arrays (i.e. array to string conversions),
// we have to ensure that all elements of the submitted choice data are strings or null.
$builder->addEventListener(FormEvents::PRE_SUBMIT, function (FormEvent $event) {
$data = $event->getData();

Expand Down
0