[FrameworkBundle] Prevent an error when the console component isn't installed #21248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you need to add the conflict rule too. Otherwise, we could end up in a case where we have framework-bundle 3.3 with console 2.2, where a BC break would happen: existing console commands would not be registered anymore |
|
@stof the conflict is already present: https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/composer.json#L60 |
|
(AppVeyor error due to a timeout, Travis should become green after the merge) |
|
then 👍 |
|
👍 |
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Jan 12, 2017
…ent isn't installed (dunglas) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] Prevent an error when the console component isn't installed | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21246 | License | MIT | Doc PR |n/a Finish #19443. Alternative to #21246. Commits ------- ab133ca [FrameworkBundle] Prevent an error when the console component isn't installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish #19443. Alternative to #21246.