[FrameworkBundle] Fix relative paths used as cache keys #21237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me. 👍 |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jan 11, 2017
…icolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Fix relative paths used as cache keys | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This bug fix is particularly important on 3.2, where the generated "templates.php" does contain relative paths. This turned out to generate a fatal error on our setup, because of non-normalized twig-cache keys. See also twigphp/Twig#2354 As a bonus, this saves us a copy-on-write on PHP 7. Commits ------- 5441e9b [FrameworkBundle] Fix relative paths used as cache keys
This was referenced Jan 12, 2017
|
I think this should be merged into symfony:3.2 and other branches as well, am I wrong? Regards. |
|
@peter17 you're right and this is what's gonna happen. It was merged to 2.7 and will eventually get to other branches too. |
This was referenced Jan 12, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug fix is particularly important on 3.2, where the generated "templates.php" does contain relative paths. This turned out to generate a fatal error on our setup, because of non-normalized twig-cache keys. See also twigphp/Twig#2354
As a bonus, this saves us a copy-on-write on PHP 7.