8000 [DI] Dont share service when no id provided by nicolas-grekas · Pull Request #21225 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DI] Dont share service when no id provided #21225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2017
Merged

[DI] Dont share service when no id provided #21225

merged 1 commit into from
Jan 10, 2017

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Jan 10, 2017
@stof
Copy link
Member
stof commented Jan 10, 2017

when can it be null ?

@nicolas-grekas
Copy link
Member Author

because of eg $this->createService($value, null) in the code

@nicolas-grekas nicolas-grekas mentioned this pull request Jan 10, 2017
Closed
@nicolas-grekas nicolas-grekas merged commit 814f633 into symfony:2.7 Jan 10, 2017
nicolas-grekas added a commit that referenced this pull request Jan 10, 2017
@nicolas-grekas
minor #21225 [DI] Dont share service when no id provided (nicolas-gre…
e355739 
…kas)

This PR was merged into the 2.7 branch.

Discussion
----------

[DI] Dont share service when no id provided

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

814f633 [DI] Dont share service when no id provided
@nicolas-grekas nicolas-grekas deleted the di-fix-share branch January 10, 2017 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug DependencyInjection Status: Needs Review
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @stof @carsonbot
0