8000 [FrameworkBundle] changed some default configs from canBeEnabled to canBeDisabled by fabpot · Pull Request #21196 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] changed some default configs from canBeEnabled to canBeDisabled #21196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2017
Merged

[FrameworkBundle] changed some default configs from canBeEnabled to canBeDisabled #21196

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98ce21a
[FrameworkBundle] changed the default value of annotation setting bas…
fabpot Jan 7, 2017
ef80873
[FrameworkBundle] changed some default configs from canBeEnabled to c…
fabpot Jan 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[FrameworkBundle] changed the default value of annotation setting bas… 
…ed on the existence of Doctrine Annotations
  • Loading branch information
@fabpot
fabpot committed Jan 7, 2017
commit 98ce21a351225c09f1c84abcedbe9e5535f33b99
4 changes: 2 additions & 2 deletions src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,7 @@ private function addValidationSection(ArrayNodeDefinition $rootNode)
->canBeEnabled()
->children()
->scalarNode('cache')->end()
->booleanNode('enable_annotations')->defaultFalse()->end()
->booleanNode('enable_annotations')->{class_exists(Annotation::class) ? 'defaultTrue' : 'defaultFalse'}()->end()
->arrayNode('static_method')
->defaultValue(array('loadValidatorMetadata'))
->prototype('scalar')->end()
Expand Down Expand Up @@ -644,7 +644,7 @@ private function addSerializerSection(ArrayNodeDefinition $rootNode)
->info('serializer configuration')
->canBeEnabled()
->children()
->booleanNode('enable_annotations')->defaultFalse()->end()
->booleanNode('enable_annotations')->{class_exists(Annotation::class) ? 'defaultTrue' : 'defaultFalse'}()->end()
->scalarNode('cache')->end()
->scalarNode('name_converter')->end()
->end()
Expand Down
0