8000 Added cache data collector and profiler page by Nyholm · Pull Request #21065 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Added cache data collector and profiler page #21065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Added cache data collector and profiler page #21065

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
23c0039
Added cache data collector and profiler page
Nyholm Dec 27, 2016
8f73434
Make sure we count hits/reads from hasItem
Nyholm Dec 29, 2016
32376dd
Update logo
Nyholm Dec 29, 2016
d63adcd
yoda style
Nyholm Jan 3, 2017
321e526
Added large summary numbers
Nyholm Jan 3, 2017
26ea3e9
rewite to show attributes
Nyholm Jan 3, 2017
9e12fac
Changed order
Nyholm Jan 3, 2017
d09bcf3
Added deletes
Nyholm Jan 3, 2017
9f1aa40
Fixed rebase
Nyholm Jan 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added large summary numbers
  • Loading branch information
@Nyholm
Nyholm committed Jan 14, 2017
commit 321e526d97fb747067affbc49f7e96ecb638c197
31 changes: 29 additions & 2 deletions src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/cache.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,43 @@

{% block panel %}
<h2>Cache</h2>
<div class="metrics">
<div class="metric">
<span class="value">{{ collector.totals.calls }}</span>
<span class="label">Total calls</span>
</div>
<div class="metric">
<span class="value">{{ '%0.2f'|format(collector.totals.time * 1000) }} ms</span>
<span class="label">Total time</span>
</div>
<div class="metric">
<span class="value">{{ collector.totals.calls }}</span>
<span class="label">Total hits</span>
</div>
<div class="metric">
<span class="value">{{ collector.totals.reads }}</span>
<span class="label">Total reads</span>
</div>
<div class="metric">
<span class="value">{{ collector.totals['hits/reads'] }}</span>
<span class="label">Hits/reads</span>
</div>
<div class="metric">
<span class="value">{{ collector.totals.writes }}</span>
<span class="label">Total writes</span>
</div>
</div>

{% for name, calls in collector.calls %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have the aggregated stats first as big numbers (as done in other panels), before having the detail for each pool

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it is not done

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I misunderstood you. I put the aggregated stats for each adapter as big numbers.
screen shot 2017-01-02 at 18 46 11

<h3>Statistics for '{{ name }}'</h3>
<div class="metrics">
{% for key, value in collector.statistics[name] %}
<div class="metric">
<span class="value">
{% if key == 'time' %}
<td>{{ '%0.2f'|format(1000*value) }} ms</td>
{{ '%0.2f'|format(1000*value) }} ms
{% else %}
<td>{{ value }}</td>
{{ value }}
{% endif %}
</span>
<span class="label">{{ key|capitalize }}</span>
Expand Down
0