[TwigBridge] Add a runtime loader to the twig bridge to ease upgrading to 3.2+ #21023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
358e45e to
7dc473c
Compare
|
As this class has nothing specific to Symfony, I suggest putting it in Twig itself |
fabpot
added a commit
to twigphp/Twig
that referenced
this pull request
Dec 23, 2016
… (chalasr) This PR was merged into the 1.x branch. Discussion ---------- Add a simple Twig_RuntimeLoaderInterface implementation Next to symfony/symfony#21023 This is related to the BC break reported in symfony/symfony#21008 which has been introduced in symfony/symfony#20093 when decoupling extensions from definitions. What I propose here is to ease the upgrade to symfony 3.2+ by adding a simple `Twig_RuntimeLoaderInterface` implementation here, useful only when using the twig-bridge outside of the symfony fullstack framework (with the Form component for instance). Upgrading would be as simple as: ```diff $twig = new Twig_Environment(...); $rendererEngine = new TwigRendererEngine(array('form_div_layout.html.twig'), $twig); - $twig->addExtension(new FormExtension(new TwigRenderer($rendererEngine, $csrfTokenManager))); + $twig->addExtension(new FormExtension()); + $twig->addRuntimeLoader(new Twig_RuntimeLoader(array(TwigRenderer::class => new TwigRenderer($rendererEngine, $csrfTokenManager))); ``` Instead of having to write this runtime loader yourself. Please see symfony/symfony#21008 for details and a concrete example of how this could help. Commits ------- 91c8d59 Add a Twig_FactoryRuntimeLoader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to the BC break reported in #21008 which has been introduced in #20093.
I think the BC break is acceptable since it is about bootstraping the form component with the twig bridge only, outside of the fullstack.
What I propose here is to ease upgrading by adding a simple runtime loader to the bridge, useful only when using the twig-bridge standalone.
So the upgrade would be as simple as:
use Symfony\Bridge\Twig\TwigRuntimeLoader; $twig = new Twig_Environment(...); $formEngine = new TwigRendererEngine(array('form_div_layout.html.twig'), $twig); - $twig->addExtension(new FormExtension(new TwigRenderer($formEngine, $csrfManager))); + $twig->addExtension(new FormExtension()); + $twig->addRuntimeLoader(new TwigRuntimeLoader(array(TwigRenderer::class => new TwigRenderer($formEngine, $csrfManager)));Instead of having to write this runtime loader yourself. UPGRADE files and documentation should be updated accordingly (with or without this PR).
Please see #21008 for details and an exemple of how this could be applied.