8000 [HttpFoundation] Improved set cookie header tests by ro0NL · Pull Request #20972 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Improved set cookie header tests #20972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[HttpFoundation] Improved set cookie header tests #20972

wants to merge 2 commits into from

Conversation

ro0NL
Copy link
Contributor
@ro0NL ro0NL commented Dec 17, 2016 •
edited
Loading
Q A
Branch? 2.7 (already in master)
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

Separated from #20569

@ro0NL ro0NL changed the title [HttpFoundation] Improved set cookie tests [HttpFoundation] Improved set cookie header tests Dec 17, 2016
fabpot
fabpot reviewed Dec 19, 2016
View reviewed changes
src/Symfony/Component/HttpFoundation/Tests/ResponseHeaderBagTest.php
@@ -294,4 +293,9 @@ public function provideMakeDispositionFail()
array('attachment', 'föö.html'),
);
}

protected function assertSetCookieHeader($expected, ResponseHeaderBag $actual)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be private, right?

@ro0NL
Copy link
Contributor Author
ro0NL commented Dec 19, 2016 •
edited
Loading

@fabpot changed to private and should get in master as well 👍

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Dec 26, 2016
@nicolas-grekas
Copy link
Member

👍

@fabpot
Copy link
Member
fabpot commented Jan 6, 2017

Thank you @ro0NL.

@fabpot fabpot closed this Jan 6, 2017
fabpot added a commit that referenced this pull request Jan 6, 2017
@fabpot
minor #20972 [HttpFoundation] Improved set cookie header tests (ro0NL)
182dd8f 
This PR was squashed before being merged into the 2.7 branch (closes #20972).

Discussion
----------

[HttpFoundation] Improved set cookie header tests

| Q             | A
| ------------- | ---
| Branch?       | 2.7 (already in master)
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

Separated from #20569

Commits
-------

05bce71 [HttpFoundation] Improved set cookie header tests
@ro0NL ro0NL deleted the http-foundation/improved-set-cookie-test branch May 5, 2017 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot left review comments

Assignees
No one assigned
Labels
HttpFoundation Status: Needs Review
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@ro0NL @nicolas-grekas @fabpot @carsonbot
0