[HttpKernel] Fix Bundle name regression #20944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. I think it should still try to parse both at once, if possible. So 👍 for this approach. |
|
Do we have a test which ensures that the name will be guessed properly if it isn't already set when |
|
@xabbuh : We don't. I've just added one, thanks (ideally those tests should be backported to lower branches I guess). |
xabbuh
reviewed
Dec 16, 2016
|
|
||
| use Symfony\Component\HttpKernel\Bundle\Bundle as BaseBundle; | ||
|
|
||
| class Bundle extends BaseBundle |
There was a problem hiding this comment.
We could put this class and the GuessedNameBundle class into the BundleTest.php file.
|
👍 |
1 similar comment
|
👍 |
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Dec 17, 2016
This PR was merged into the 3.3-dev branch. Discussion ---------- [HttpKernel] Fix Bundle name regression | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20117 | License | MIT | Doc PR | N/A The bundle name can be set manually instead of being guessed from the class name, as the property is protected. However, a regression prevents this name to be used, as calling `Bundle::getNamespace()` recomputes the bundle name from class instead. The ability to name explicitly bundles is appreciable when dealing with "virtual" ones, or when providing bundles in a library under a `Vendor\MyPackage\Bridge\Symfony\Bundle` namespace. No need to rename the bundle class `VendorMyPackageBundle` which will make the instantiation in `Kernel::registerBundle()` quite ugly: ```diff - new Vendor\MyPackage\Bridge\Symfony\Bundle\VendorMyPackageBundle() + new Vendor\MyPackage\Bridge\Symfony\Bundle\Bundle() ``` What about removing `Bundle::parseClassName()` and processing the namespace and bundle name separately, but keeping the `namespace` property introduced in #20117? Commits ------- 3b5127d [HttpKernel] Fix Bundle name regression
|
@fabpot this seems to be missing from 3.2 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bundle name can be set manually instead of being guessed from the class name, as the property is protected.
However, a regression prevents this name to be used, as calling
Bundle::getNamespace()recomputes the bundle name from class instead.The ability to name explicitly bundles is appreciable when dealing with "virtual" ones, or when providing bundles in a library under a
Vendor\MyPackage\Bridge\Symfony\Bundlenamespace. No need to rename the bundle classVendorMyPackageBundlewhich will make the instantiation inKernel::registerBundle()quite ugly:What about removing
Bundle::parseClassName()and processing the namespace and bundle name separately, but keeping thenamespaceproperty introduced in #20117?