[WebProfilerBundle] Fix PHP extensions in the toolbar #20926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I'm sorry I didn't update this when changing the PHP Config panel. Thanks for fixing it. Status: reviewed |
|
Good catch, thanks @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Dec 15, 2016
…gizanagi) This PR was merged into the 3.3-dev branch. Discussion ---------- [WebProfilerBundle] Fix PHP extensions in the toolbar | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | yes (adding other extensions info) | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20697 | License | MIT | Doc PR | N/A `ConfigDataCollector::hasAccelerator()` has been removed. Except if we want to reintroduce the method, I'd suggest to add apcu & opcache infos directly (or just remove the accelerator line). Commits ------- 2495030 [WebProfilerBundle] Fix PHP extensions in the toolbar
ogizanagi
referenced
this pull request
in symfony/web-profiler-bundle
Dec 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfigDataCollector::hasAccelerator()has been removed.Except if we want to reintroduce the method, I'd suggest to add apcu & opcache infos directly (or just remove the accelerator line).