[Finder] Deprecate ExceptionInterface #20884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 as is. It does not "cost" us anything to deprecate it in 3.3 and remove it in 4.0. |
|
Good catch, thanks @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Dec 13, 2016
This PR was merged into the 3.3-dev branch. Discussion ---------- [Finder] Deprecate ExceptionInterface | Q | A | ------------- | --- | Branch? | master | Bug fix? 7497 | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A This interface was missed in #15805, and should have been removed in 3.0. Ideally, the component should have such an interface, though, as other components does. But the only domain exception in this component is an `AccessDeniedException` used by the `RecursiveDirectoryIterator`. So it isn't worth it right now. I think this interface was almost internal actually, but anyway the `\Symfony\Component\Finder\Adapter\AdapterInterface` interface does not exist anymore. So the `ExceptionInterface::getAdapter()` signature cannot be satisfied anyway. I guess anyone relying on this interface in any way should have notice that and removed anything related to Symfony Finder's adapters when upgrading to 3.0. Should we consider removing it directly in the 3.1 branch instead? Commits ------- 1b600b0 [Finder] Deprecate ExceptionInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interface was missed in #15805, and should have been removed in 3.0.
Ideally, the component should have such an interface, though, as other components does. But the only domain exception in this component is an
AccessDeniedExceptionused by theRecursiveDirectoryIterator. So it isn't worth it right now.I think this interface was almost internal actually, but anyway the
\Symfony\Component\Finder\Adapter\AdapterInterfaceinterface does not exist anymore. So theExceptionInterface::getAdapter()signature cannot be satisfied anyway. I guess anyone relying on this interface in any way should have notice that and removed anything related to Symfony Finder's adapters when upgrading to 3.0.Should we consider removing it directly in the 3.1 branch instead?