8000 [WebProfilerBundle] Fix whitespace control in layout.html.twig by nicolas-grekas · Pull Request #20832 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WebProfilerBundle] Fix whitespace control in layout.html.twig #20832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2016
Merged

[WebProfilerBundle] Fix whitespace control in layout.html.twig #20832

merged 1 commit into from
Dec 8, 2016

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

nicolas-grekas referenced this pull request Dec 8, 2016
@nicolas-grekas
bug #20831 [Twig] Fix deprecations with Twig 1.29 (nicolas-grekas)
be5a5e4 
This PR was merged into the 2.7 branch.

Discussion
----------

[Twig] Fix deprecations with Twig 1.29

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20829
| License       | MIT
| Doc PR        | -

Commits
-------

9218cac [Twig] Fix deprecations with Twig 1.29
javiereguiluz
javiereguiluz approved these changes Dec 8, 2016
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stof
Copy link
Member
stof commented Dec 8, 2016

I suggest using it on both sides of each tag, making it much less likely to introduce bugs when forgetting it in 1 place during changes

@stof
Copy link
Member
stof commented Dec 8, 2016

👍
Status: reviewed

@nicolas-grekas nicolas-grekas merged commit d052fa9 into symfony:2.7 Dec 8, 2016
nicolas-grekas added a commit that referenced this pull request Dec 8, 2016
@nicolas-grekas
minor #20832 [WebProfilerBundle] Fix whitespace control in layout.htm…
56c3eef 
…l.twig (nicolas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[WebProfilerBundle] Fix whitespace control in layout.html.twig

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

d052fa9 [WebProfilerBundle] Fix whitespace control in layout.html.twig
@nicolas-grekas nicolas-grekas deleted the fix-ws branch December 8, 2016 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @stof @javiereguiluz @carsonbot
0