[FrameworkBundle] [Workflow] Fix service marking store configuration #20760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
…s in configuration
Contributor
Author
|
Also tests added |
d10d90b to
1bc83c5
Compare
stof
approved these changes
Dec 8, 2016
| from: | ||
| - first | ||
| to: | ||
| - last |
Member
|
👍 |
…njection/Fixtures/yml/workflows.yml
Member
|
Thank you @fduch. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 8, 2016
…figuration (fduch) This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes #20760). Discussion ---------- [FrameworkBundle] [Workflow] Fix service marking store configuration | Q | A | ------------- | --- | Branch? | "master" | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | no | License | MIT | Doc PR | no Currently workflow marking store configuration [checks](https://github.com/symfony/symfony/blob/3.2/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L271-L272) that `service` and `arguments` fields are not specified simultaneously using `isset` function. Since [arguments node](https://github.com/symfony/symfony/blob/3.2/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L253-L261) defines prototype node inside, even if `arguments` node is not specified, - after processing it looks like empty array. If `service` setting is set it leads to failing build with validation error message (due to `isset([])` returns `true`): `"arguments" and "service" cannot be used together.`. This patch addresses this issue. Commits ------- 3289b10 [FrameworkBundle] [Workflow] Fix service marking store configuration
This was referenced Dec 12, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently workflow marking store configuration checks that
serviceandargumentsfields are not specified simultaneously usingissetfunction.Since arguments node defines prototype node inside, even if
argumentsnode is not specified, - after processing it looks like empty array. Ifservicesetting is set it leads to failing build with validation error message (due toisset([])returnstrue):"arguments" and "service" cannot be used together..This patch addresses this issue.