-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Workflow] Introduce concept of SupportStrategyInterface #20751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
6421c10
bfd3611
c0cbc85
fa448af
19fb676
faddc97
a115bdd
d22fe01
047a2e7
a34e4af
1e65b12
f4e0d62
2d11004
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,7 @@ class Registry | |
private $workflows = array(); | ||
|
||
/** | ||
* @param Workflow $workflow | ||
* @param Workflow $workflow | ||
* @param string|SupportStrategyInterface $supportStrategy | ||
*/ | ||
public function add(Workflow $workflow, $supportStrategy) | ||
|
@@ -40,7 +40,7 @@ public function add(Workflow $workflow, $supportStrategy) | |
} | ||
|
||
/** | ||
* @param object $subject | ||
* @param object $subject | ||
* @param null|string $workflowName | ||
* | ||
* @return Workflow | ||
|
@@ -67,10 +67,10 @@ public function get($subject, $workflowName = null) | |
} | ||
|
||
/** | ||
* @param Workflow $workflow | ||
* @param Workflow $workflow | ||
* @param string|SupportStrategyInterface $supportStrategy | ||
* @param object $subject | ||
* @param null|string $workflowName | ||
* @param object $subject | ||
* @param null|string $workflowName | ||
* | ||
* @return bool | ||
*/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no need for this docblock IMO as the method is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Several other private methods (e.g. in Workflow.php) have a docblock as well. Is there any rule of thumb when to add it? I personally like having docblocks, but if they are not common in Symfony core I am fine with removing those. |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be reverted