8000 [WebProfilerBundle] Fix toolbar max-width for long ajax url · Pull Request #20713 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WebProfilerBundle] Fix toolbar max-width for long ajax url #20713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WebProfilerBundle] Fix toolbar max-width for long ajax url #20713

wants to merge 1 commit into from

Conversation

ghost
Copy link
@ghost ghost commented Dec 1, 2016 •
edited by ghost
Loading
Q A
Branch? 3.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

Before :
toolbar

After :
toolbar2

@chalasr chalasr mentioned this pull request Dec 1, 2016
Merged
@ogizanagi
Copy link
Contributor
ogizanagi commented Dec 1, 2016 •
edited
Loading

I don't have this issue using 3.2. I actually think it was fixed silently in #19576.
So it should be fixed in 2.8, and I think it should use the same patch.

See #20715 which is closer IMHO.

@ghost
Copy link
Author
ghost commented Dec 1, 2016

@ogizanagi i have this issue on 3.2, look the screenshot, the column "xhr"

@ogizanagi
Copy link
Contributor
ogizanagi commented Dec 1, 2016 •
edited
Loading

Humpf, indeed. I missed that, sorry. 😕

On my own side, no matter what length the url is, I cannot reproduce:

screenshot 2016-12-01 a 20 54 56

@ghost
Copy link
Author
ghost commented Dec 1, 2016 •
edited by ghost
Loading

@ogizanagi I think our fonts doesn't have the same width

@ghost
Copy link
Author
ghost commented Dec 1, 2016 •
edited by ghost
Loading

@ogizanagi I think our fonts doesn't have the same width

@ogizanagi This is actually the reason for my issue (* { font-family:verdana } in my css) ! ... forgive this PR ;-)

@ghost ghost closed this Dec 1, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogizanagi @carsonbot
0