8000 [VarDumper] Use default color for ellipsed namespaces/paths by nicolas-grekas · Pull Request #20679 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[VarDumper] Use default color for ellipsed namespaces/paths #20679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2016
Merged

[VarDumper] Use default color for ellipsed namespaces/paths #20679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/profiler.css.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,6 +900,7 @@ table.logs .metadata {
#collector-content .sf-dump-note { color: #6897BB; }
#collector-content .sf-dump-key { color: #789339; }
#collector-content .sf-dump-ref { color: #6E6E6E; }
#collector-content .sf-dump-ellipsis { color: #CC7832; max-width: 100em; }

#collector-content .sf-dump {
margin: 0;
Expand Down
3 changes: 2 additions & 1 deletion src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ class HtmlDumper extends CliDumper
'meta' => 'color:#B729D9',
'key' => 'color:#56DB3A',
'index' => 'color:#1299DA',
'ellipsis' => 'color:#FF8400',
);

private $displayOptions = array(
Expand Down Expand Up @@ -380,7 +381,7 @@ function isCtrlKey(e) {
display: inline-block;
overflow: visible;
text-overflow: ellipsis;
width: 5em;
max-width: 5em;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bug fix actually

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it go in older branches too ? Or is it only affecting 3.2 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only 3.2, where ellipsis are introduced

white-space: nowrap;
overflow: hidden;
vertical-align: top;
Expand Down
0