8000 [HttpFoundation] Fix isMethodSafe test for cacheables by chalasr · Pull Request #20640 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Fix isMethodSafe test for cacheables #20640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2016
Merged

[HttpFoundation] Fix isMethodSafe test for cacheables #20640

merged 1 commit into from
Nov 26, 2016

Conversation

chalasr
Copy link
Member
@chalasr chalasr commented Nov 25, 2016
Q A
Branch? 2.7
Tests pass? yes
License MIT

@xabbuh
Copy link
Member
xabbuh commented Nov 25, 2016

👍

@nicolas-grekas
Copy link
Member

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit 2699009 into symfony:2.7 Nov 26, 2016
nicolas-grekas added a commit that referenced this pull request Nov 26, 2016
@nicolas-grekas
minor #20640 [HttpFoundation] Fix isMethodSafe test for cacheables (c…
777cdfc 
…halasr)

This PR was merged into the 2.7 branch.

Discussion
----------

[HttpFoundation] Fix isMethodSafe test for cacheables

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Tests pass?   | yes
| License       | MIT

Commits
-------

2699009 [HttpFoundation] Fix test ensuring isMethodSafe() checks cacheable
@chalasr chalasr deleted the fix/method_safe_cacheable_test branch November 26, 2016 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
HttpFoundation Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalasr @xabbuh @nicolas-grekas @carsonbot
0