8000 [Form] [Validator] Update documentation link to the component by CoolGoose · Pull Request #20629 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Form] [Validator] Update documentation link to the component #20629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

CoolGoose
Copy link
Contributor
@CoolGoose CoolGoose commented Nov 25, 2016
  • Update documentation link to the component since it has standalone examples

Update documentation link to the component since it has standalone examples
@CoolGoose CoolGoose changed the title Update documentation link to the component [Form][Validator] Update documentation link to the component Nov 25, 2016
@CoolGoose CoolGoose changed the title [Form][Validator] Update documentation link to the component [Form] [Validator] Update documentation link to the component Nov 25, 2016
@nicolas-grekas
Copy link
Member

Thank you @CoolGoose.

nicolas-grekas added a commit that referenced this pull request Nov 25, 2016
…onent (CoolGoose)

This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #20629).

Discussion
----------

[Form] [Validator] Update documentation link to the component

- [x] Update documentation link to the component since it has standalone examples

Commits
-------

25a6294 Update documentation link to the component
@@ -7,7 +7,7 @@ The Validator component provides tools to validate values following the
Resources
---------

* [Documentation](https://symfony.com/doc/current/book/validation.html)
* [Documentation](https://symfony.com/doc/current/components/validator.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have used http://symfony.com/doc/current/validation.html instead which shows the integration into the full-stack framework (like the old document did).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all other components link to their https://symfony.com/doc/current/components/* page...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xabbuh the problem is that I want to use the "component" no the symfony integration :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolas-grekas is right. I guess we just linked to the book chapter here before because the Validator component docs were added a long time after the book chapter and we hadn't anything else to link to. Thus, your change is actually perfect and I was wrong @CoolGoose. :) Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xabbuh No problem :) thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0