Tag missing internals #20626
Merged
Tag missing internals #20626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | N/A |
| License | MIT |
| Doc PR | N/A |
|
👍 Status: reviewed |
| * @param \DOMElement $node | ||
| * | ||
| * @throws \LogicException When choice provided is not multiple nor radio | ||
| * | ||
| * @internal Should not be used by user-land code. |
There was a problem hiding this comment.
Comment doesn't add anything to the annotation, I'd suggest removing it, same below
There was a problem hiding this comment.
Agreed. I've added this one for consistency with other occurrences in the codebase (https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/ChoiceList/Factory/CachingFactoryDecorator.php#L51 for instance).
Anyway, I've removed it including original comments.
|
👍 |
1 similar comment
|
👍 |
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 25, 2016
This PR was merged into the 2.7 branch. Discussion ---------- Tag missing internals | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Commits ------- 97e94b4 Tag missing internals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.